Testimonials grid section using HTML & CSS
Design comparison
Solution retrospective
Thank you for any feedback
Community feedback
- @correlucasPosted over 2 years ago
Hello Asmaa, how are you? Congratulations for your solution!
I'm kinda intrigued why you grid doesn't get centered in the screen, I took a look and don't get It. I'll open the GitHub to understand it better and comeback here to give you a feedback.
The overall solution is really good and I think you did good using the grid-area. In my solution I've used
grid-column: span 2;
to set card span 2 columns =) you did it better!Meanwhile you can fix 2 accessibility issues, one is related to the page language, you can set in the html as
<html lang="en">
and the other is that you jump some heading direct to the h4, you should ever follow the sequence h1, h2, h3...I hope it helps you!
Marked as helpful0@asmaa-elfatayryPosted over 2 years ago@correlucas Thank you Lucas for your comment. It really helped me. and I will fix the accessibility issues
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord