Design comparison
Solution retrospective
I don't know why when I look at the live site, everything is as it should be, but the screenshot generated by frontendmentor for some reason shows text overflow on the far right div????
my best attempt using css grids to do the testimonials grid section challenge. I need help on how to adjust font size to be responsive to div size. I had to manually adjust the font size to fit into the container that had a fixed size and I feel like there is a better solution.
Community feedback
- @pikapikamartPosted over 3 years ago
Great work you got there.
Your layout seems pretty fine to me and the text are not floated as well, maybe it is just a bug. You could just generate another screenshot if you like, but it is like 5 time only per month for a free user.
Also, manually adjusting font-size, there is nothing wrong with that. But if you want a responsive font-size, we typically use
clamp
function when doing that.clamp
takes 3 arguments.clamp(min size, preferred, max-size)
. Min size is the minimum, preferred is the current size that you want to apply, max-size is the maximum. An example would be thatclamp(1rem, 50%, 3rem)
. But we use this if we want our sizes, clamp applies to all elements, (I guess). We use this when we want something to scale down when it reaches mobile state. So that we don't need to specify the sizes in themedia
queries.Another suggestion in your layout will be that, lowering down or creating a layout for other breakpoints. Because at point
1088px
going down to the breakpoint, a scrollbar appears at the bottom which we want to avoid. Checking that one out will be awesome.Mobile view seems fine but there is a one large section of white spaces at the bottom.
Overall, you did a good job in here^^
0@jamby4546Posted over 3 years agothank you! this was VERY valuable feedback. i had never heard of clamp, and I will definitely be experimenting with it in the next few projects
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord