Design comparison
SolutionDesign
Solution retrospective
This is my first time doing a challenge here. Please review my code, it helps me a lot.
Community feedback
- @vanzasetiaPosted over 3 years ago
๐Hi there!
I have some feedback for this solution:
- Instead of keep adding
body main
and etc. I recommend to select directly the class name rather than keep increasing specificity, like this:
.testimonials { /* some styles */ } .testim-box1 { /* some styles */ }
- I recommend to fill the
alt
with their name rather thanavatar
.
That's it! Hopefully this is helpful!
Marked as helpful1 - Instead of keep adding
- @radenadriPosted over 3 years ago
Nice work man! It works greatly on tablet and mobile as well! ๐
From what i see, i think i only have two additions based on my personal opinions :
- It will be much more awesome if you add the box-shadow on each testimonials, just a thin shadow to make it look exactly like the design. But overall its great, its only little additions as well. ๐
- I believe the provided design showing that the avatar is kind of small, if you change it to approximately 45px, i think it will be much more great since it will be much more clearer to see the picture.
That's it, great work for sure! Happy coding and also keep coding man! Waiting for another work! ๐๐
Marked as helpful1@dngtnvPosted over 3 years ago@radenadri Wow, thanks for the feedback, i'll try to change that.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord