Testimonials Grid Section Using CSS Grid

Community feedback

• 

  KARTHIK•320

  @thekarthikrPosted almost 2 years ago

  Hey Mohammad Talim, Absolute units(px ) are always fixed the value doesn't change. On the other hand Relative units are responsive For example % is Relative to the size of the container, vh and vw are relative to the viewport, and em and rem are relative to the font size. You can use rem units for fonts and em units for media queries. WHAT UNIT YOU USE IT DEPENDS ON WHAT PROBLEM YOU TRYING TO SOLVE.

  Hope it helps. Have a great time.

  Marked as helpful

  0
• 

  バレンタイン 😈•64,190

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • The article element is not the best choice ❌ for wrapping these testimonials. In order to use the article element the component needs to be able to make sense on its own and be independently distributable (can be used in on another site). These testimonials cannot do neither.

  More Info:📚

  MDN Article Element

  • For the testimonials, it is best ✅ to to wrap each individual testimonial component in a figure element, the individuals information should be wrapped in a figcaption element and lastly, the testimonial itself should be wrapped in a blockquote element.

  Code:

  <figure>
     <figcaption></figcaption>
     <blockquote></blockquote>
  </figure>
  

  More Info:📚

  MDN Figure Element

  • The headings in your component are being used incorrectly❌ . Since the h1 heading can only be used once ⚠️, it is always given to the heading with the highest level of importance. This component has several headings of equal importance, so the best option would be to use an h2 heading ✅ since it is reusable and it will give each heading the same level of importance.

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 🎆🎊🪅

  0