@VCarames
Posted
Hey @husamasaad, some suggestions to improve you code:
Kevin Powell is the best! I learn a lot new thing from his channel.
-
Not sure if it is my browser, but as the screen shrinks your component stretches out vertically to the ends of my screen and gets stuck until the media query starts or I refresh the browser.
-
Add a third layout to make the transition from mobile 📱 -> desktop 🖥 views smoother.
-
I would not wrap these component in articles elements, as mentioned above/below. These components are not able to stand and do make sense on their own (which is a requirement for using the article element).
Instead, you want to wrap each individual testimonial component in a Figure Element, the individuals information should be wrapped in a Figcaption Element and lastly, the testimonial itself should be wrapped in a Blockquote Element.
Code:
<figure>
<figcaption></figcaption>
<blockquote></blockquote>
</figure>
More Info:
Happy Coding! 👻🎃
Marked as helpful