Design comparison
SolutionDesign
Solution retrospective
Hello World,
Here's my solution to this challenge. Let me know if I can Improve that in any way
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- To not only improve your HTML code but to also identify the main content of you page, you will want to wrap your entire site inside the
main
element.
More Info:📚
- The profile images alt tags need to be improved. It should state the following; “Headshot of -person’s full name-“
More Info:📚
- The names of each individual are headings so they should be wrapped in a Heading Element. Since they are all equal level of importance, the
h2
heading will be the best choice.
- To improve the semantics of your component, you will want to wrap each individual testimonial component in a Figure Element, the individuals information should be wrapped in a Figcaption Element and lastly, the testimonial itself should be wrapped in a Blockquote Element.
Code:
<figure> <figcaption></figcaption> <blockquote></blockquote> </figure>
More Info:📚
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding!🎄🎁
Marked as helpful0 - To not only improve your HTML code but to also identify the main content of you page, you will want to wrap your entire site inside the
- @sulemaan7070Posted almost 2 years ago
hey yele😄(fellow one piece fan🫂).good job, you can make it better by
- Centering the whole thing.
- giving a slight box-shadow..🔥🔥 Happy coding💯
Marked as helpful0 - @catherineisonlinePosted almost 2 years ago
Looks amazing! Might need to wrap everything the main tag though to remove some report issues 😊
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord