@R3ygoski
Posted
Hello again Louise, congratulations on completing your project, it looks very similar to the proposed design, well done.
Regarding your question, yes, the way you did it is correct. If you had chosen to use grid for mobile as well, it would have worked. Using flex ends up being simpler than using grid, so I believe the best approach for mobile is indeed to use flex, as you did.
A tip regarding CSS: to avoid having a CSS file with too much content, try breaking it into other files, creating a reset.css, responsive.css, and linking them in the HTML through <link> (similar to how it is done to link style.css). This way, you bring extra organization to the project.
And about the HTML, I noticed you used several <h1> tags, the correct way is to have only one <h1> tag per page. The best practice would be to use <h2> and <h3> for the testimonials, and if you want to include an <h1>, you can place it outside the cards and use display: none; to make it disappear (note that this will still allow it to be read by screen readers).
Once again, congratulations on completing your project, it turned out really well. If anything I said caused any doubt, please ask below and I will try to help as best as I can.
Marked as helpful
@atheenaoteyza
Posted
@R3ygoski thanks so much I didn't know that about h1, and you're right it is more organize if I will put other things on diff css file, will apply this tip on my next projects. thanks again! :-)
