Testimonials grid section

Community feedback

• 

  Abhik•4,840

  @abhik-bPosted almost 3 years ago

  👋 Hello Stephen , Your solution looks perfect to me 🙌🙌 and Yes react definitely makes life easier !!

  Just some of my opinions which can help you :

  • You can create components for each article(testimonial) & rendered all of them inside testimonials component & this way your code would have been more easy to read.
  • For the heading accessibility issue you can read this nice article

  Very well done 🥳🥳🥳 & please keep contributing such amazing solutions 🤩

  Marked as helpful

  1

  ---

  

  stephmunez•435

  @stephmunezPosted almost 3 years ago

  Hey @abhik-b, appreciate the compliment and its complementary feedback 🙂

  • You're right, that would be better, never thought of it. Btw, it came up to my mind, would you think it's also good to create 1 article and use props instead of hard coding each content but then would need to make a data file for it right? or it would be more complicated with the different layout of the cards?
  • Thank you so much for the nice article, it helped a lot.

  Will keep them coming for sure! Have a nice day

  1

  

  Abhik•4,840

  @abhik-bPosted almost 3 years ago

  @stephjoseph I think for this challenge you can create different components for each testimonial because each testimonial looks different so hard coding is justified here. I am glad my feedback was helpful to you & you have a nice day too 😃

  1

  

  stephmunez•435

  @stephmunezPosted almost 3 years ago

  Got it @abhik-b, that makes sense. So basically, let's not make our lives harder here haha

  Btw I already created the different components 👍🏽

  Thanks again, cheers 🙂

  1

  

  Abhik•4,840

  @abhik-bPosted almost 3 years ago

  @stephjoseph Haha 😅 Yes It looks perfect now , cheers 🥳

  1