Design comparison
Solution retrospective
I did some study on css grid and i was able to do this please give your honest opinions and also i am open to corrections Thank you
Community feedback
- @MelvinAguilarPosted almost 2 years ago
Hello there ๐. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
HTML ๐:
-
One of the key characteristics of
<article>
tags is that they are self-contained, meaning that the content within the tag is complete and can be understood on its own, without any additional context from the rest of the page.In this case there is a
<article>
tag only to have the testimonial, does this information independent content? Or does it need more context? In my humble opinion, it is not necessary to use the<article>
tag.
-
Tip: To improve the semantics of your code you should use the
<figure>
and<blockquote>
tags to wrap the testimonials, with this, you will be able to encapsulate the author and the citation of the testimonial.Example:
<figure> <blockquote> <p>"Example of a testimonial"</p> </blockquote> <figcaption> <p>Example of the author</p> </figcaption> </figure>
You can read more about the
<figure>
and<blockquote>
tags with this two links:
I hope you find it useful! ๐ Above all, the solution you submitted is great!
Happy coding!
Marked as helpful0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord