Design comparison
Solution retrospective
Creo que lo he hecho bien, dime los comentarios que te parece mi solución, y no olvides de darle like si te ha gustado :)
Community feedback
- @AdrianoEscarabotePosted almost 2 years ago
Hello Moises Roberto, how are you? I truly loved your project's outcome, however I have some advice that I hope you'll find useful:
The main tag must be present in every HTML document so that we can recognize the main content. To fix this, wrap the main content in the main tag. Users of assistive technology will have a better navigation experience on your site thanks to the use of HTML5 landmark elements.
avoid using
px
, If your web content font sizes are set to absolute units, such as pixels, the user will not be able to re-size the text or control the font size based on their needs. if you want to keep using px for development and then format the whole code to rem, you can use this vscode extension: px to remleave the
h1
tag only for the main page title!The remainder is excellent.
I hope it's useful. 👍
Marked as helpful1@MoisesRmxPosted almost 2 years ago@AdrianoEscarabote I can replace the "div contenedor" for the "main contenedor"? :/
0@MoisesRmxPosted almost 2 years ago@AdrianoEscarabote In my report it seems to have worked. Thank you very much :)
1 - Account deleted
Hola @MoisesRmx! Me gustó mucho tu solución 🙌 La única recomendación que podría hacer sería que no utilices más de una
<h1>
por documento. Si bien es posible, es una práctica poco recomendable por razones de accesibilidad.Échale un ojo a: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Heading_Elements
También, como un extra intenta aprender acerca de las propiedades personalizadas: https://developer.mozilla.org/en-US/docs/Web/CSS/--* Espero que te resulte útil.
¡Un abrazo!
Marked as helpful1@MoisesRmxPosted almost 2 years ago@rwxdan Gracias, igualmente un abrazo... Voy a buscar las propiedades personalizadas :)
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord