@0xabdulkhaliq
Posted
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have a suggestion regarding your code that I believe will be of great interest to you.
MAKING ACCESSIBLE TESTIMONIALS :
- Currently the Testimonials are not accessible because of the using wrongs elements.
<section>
<img src="images/bg-pattern-quotation.svg" alt="" class="card__img-quotation">
<header class="card__header">
Author Details
</header>
<div class="card__quote">
<p>
Title
</p>
<p>
Quote
</p>
</div>
</section>
- For example:
<figure>
<figcaption>
<img src="./assets/images/image-daniel.jpg" alt="Daniel Clifford" />
<div>
<p>
<span class="sr-only">Testimony Author</span>
Daniel Clifford
</p>
<p>Verified Graduate</p>
</div>
</figcaption>
<blockquote>
<h2>
Testimonial Title
...
</h2>
<p>
Testimonial Quote
...
</p>
</blockquote>
</figure>
- Additionally, you want to add proper alt for
img
inside testimonials because they are not for decoration, It will help us to tell the user who is the author of the testimonial, its recommended to use the author's name as the alt attribute value likealt="Daniel Clifford"
- If you have any questions or need further clarification feel free to reach out to me.
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!