testimonials grid section main

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hello @fica25, congratulations on your new solution!

  Your html is working but you can improve it using meaningful tags and replace the divs, for example the main div that takes all the content can be wrapped with <main> or section, about the cards you can replace the <div> that wraps each card with <article> you can wrap the paragraph with the quote with the tag <blockquote> this way you'll wrap each block of element with the best tag in this situation. Note that <div> is only a block element without meaning, prefer to use it for small blocks of content.

  This article from Freecodecamp explains the main HTML semantic TAGS: https://www.freecodecamp.org/news/semantic-html5-elements/

  ✌️ I hope this helps you and happy coding!

  0
• 

  Hamid Mahmood•540

  @Hamid210545Posted about 2 years ago

  Hello there! You have done an amazing job ... but let me know you that your web page is not responsive on mobile screen (375px) .... you should take a look at that.... Thanks!

  0

  ---

  

  Filip•110

  @fica25Posted about 2 years ago

  @Hamid210545 Hi. Thanks for great comment. I did display:flex for mobile screen (max-width:375px) as its said in instruction.I dont know how you didnt see, check it when you inspect page on 375px. Greetings!

  0

  

  Hamid Mahmood•540

  @Hamid210545Posted about 2 years ago

  @fica25 hello ... I did checked it on mobile screen right now ..... You should use display: grid ; instead of display (flex)......... Can you please check out my solution for that...... Thanks !

  0
• 

  Kehinde Hussein, Fasunle•190

  @FasunlePosted about 2 years ago

  Hi Filip,

  You have done a great job. You just need to make some modifications for accessibility reasons. Make sure that all img tags have alt attribute with strings to summarize what the image is.

  For example, <img src="images/image-kira.jpg" class="profile-img" alt="App Logo" />

  Also, change all the backticks to single or double quotes.

  I hope you find this helpful.

  0

  ---

  

  Filip•110

  @fica25Posted about 2 years ago

  @Fasunle Hey , thanks for comment and advice. I know for this but sometimes I forget to put it. I'll pay attention to this next time. Bye!

  1