Design comparison
Solution retrospective
Hey guys! This is my second project using css grid, I think I have a lot to improve in my grid structure, I'd like to know what I could have done better in this code?
Community feedback
- @correlucasPosted about 2 years ago
👾Hello @nicolas055, congratulations on your new solution!
I’ve some suggestions for you:
Your html is working but you can improve it using meaningful tags and replace the divs, for example the main div that takes all the content can be wrapped with
<main>
or section, about the cards you can replace the<div>
that wraps each card with<article>
you can wrap the paragraph with the quote with the tag<blockquote>
this way you'll wrap each block of element with the best tag in this situation. Note that<div>
is only a block element without meaning, prefer to use it for small blocks of content.This article from Freecodecamp explains the main HTML semantic TAGS: https://www.freecodecamp.org/news/semantic-html5-elements/
Add the website favicon inserting the svg image inside the
<head>
.<link rel="icon" type="image/x-icon" href="./images/favicon-32x32.png">
✌️ I hope this helps you and happy coding!
Marked as helpful1@nicolas055Posted about 2 years agoHello Lucas , Thanks for helping me with your feedback!
In my next challenge I'll use more semantic tags.
Thank you very much!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord