Design comparison
Solution retrospective
Nice challenge to learn about css grid layout. Learn more about grid and make responsive that grid section is also very good learning for me.
Any feedback from your side is appreciated.
Keep learning... keep coding...
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there š. Congratulations on successfully completing the challenge! š
- I have other recommendations regarding your code that I believe will be of great interest to you.
HTML š·ļø:
- This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to
non-semanticmarkup, which lack landmark for a webpage
- So fix it by replacing the
<div class="main">element with the semantic element<main>in yourindex.htmlfile to improve accessibility and organization of your page.
- What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like
<div>or<span>
- They convey the structure of your page. For example, the
<main>element should include all content directly related to the page's main idea, so there should only be one per page
.
I hope you find this helpful š Above all, the solution you submitted is great !
Happy coding!
0 - @Daniel-BilodidPosted over 1 year ago
Hi, my congratulations you did a great job š
ššØš¦š šš¢š©š¬ ššØš« š²šØš®š« ššØšš š
š¹ You need to put a landmark in your code
simply wrap your code with <main> landmark
š The <main> HTML element is intended for the main content (content) of the <body> of the document (page).
I hope it was helpful, you are great, keep up the good work š
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord