Design comparison
Solution retrospective
Okay, I used the style="" element in the html tags for each specific color for the text and individual tags. Is that bad practice? I found it a lot easier than coding it using html as I could target a specific HTML element without having to create another class to target it using CSS.
Community feedback
- @Zy8712Posted about 1 year ago
Your site looks pretty good. Great job!
To answer your question, a lot of people consider it to be bad practice for a variety of reasons. I think the biggest reason is that it makes it more difficult to reuse, maintain, and scale. This is especially true when trying to keep code readable and organized.
In your case, a smaller project like this might be okay. My recommendation is that if you have css in a separate file, you shouldn't have a couple random stray lines of inline-css. That way people can find the css where they expect it to be.
Hope you find this feedback useful 👍
Marked as helpful1
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord