Design comparison
SolutionDesign
Solution retrospective
Hi, is it me or is the p-tags colors are not the same as the one on the design?
Also, Feedback is appreciated, Thank you
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- The profile images alt tags need to be improved. It should state the following; “Headshot of -person’s full name-“
More Info:📚
- Your use of headings is incorrect since the
h1
heading can only be used once per page.
- The only headings in this component are the names of each individual; “Daniel Clifford”, “Jonathan Walters”, “Jeanette Harmon”, “Patrick Abrams” and “Kira Whittle”. Everything else should be wrapped in a paragraph Element.
- To improve the semantics of your component, you will want to wrap each individual testimonial component in a Figure Element, the individuals information should be wrapped in a Figcaption Element and lastly, the testimonial itself should be wrapped in a Blockquote Element.
Code:
<figure> <figcaption></figcaption> <blockquote></blockquote> </figure>
More Info:📚
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding!🎄🎁
Marked as helpful1 - @catherineisonlinePosted almost 2 years ago
Looks nice! After around 1182px the container is too close to the top, right want to add a bit more margin 🙌🏻
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord