@CodePapa360
Posted
Hi AbdulRhmanπ Great job on completing this challenge! π₯³
I did notice a few areas where your code could be improved.
Some bad practices:
-
Instead of using
<br>
tags to create line breaks, it would be better to use<p>
tags and addmargin
orpadding
to create space between elements. -
Instead of using inline styles like
style="font: inherit;"
, it would be better to define your styles in a separate CSS file or in a
Some CSS suggestions:
-
Use
class
orid
selectors instead of element selectors to be more specific and avoid unintended styling. -
Use
box-sizing: border-box
on all elements to include padding and border in the element's total width and height. -
Consider using a CSS reset or normalize stylesheet to ensure that your styles consistently apply across different browsers.
-
Use the
rem
unit instead ofpx
for font sizes and other dimensions to make it easier to scale your design.
Overall, this is a very well done solution to the challenge. Great job!
I hope this feedback was helpful. π Keep up the good work!π
@VCarames
Posted
@CodePapa360
This two comments make no sense ;
- He already using semantic elements (
figure
,figcaption
andblockquote
). - There is no
form
needed in this challenge. - He IS using a
media query
.
- Use semantic HTML tags like <header>, <nav>, and <footer> to give meaning to your content and make it easier for search engines and assistive technologies to understand the structure of your page.
- Consider using <label> tags to associate form inputs with their labels for improved usability.
- Use the @media rule to define responsive styles that apply at different screen sizes.