Responsive, "mobile first", grid display project

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • For the testimonials, it is best ✅ to to wrap each individual testimonial component in a figure element, the individuals information should be wrapped in a figcaption element and lastly, the testimonial itself should be wrapped in a blockquote element.

  Code:

  <figure>
     <figcaption></figcaption>
     <blockquote></blockquote>
  </figure>
  

  More Info:📚

  MDN Figure Element

  • For the profile images alt tag description, it should never* ❌ include the following keywords; “image”, “photo”., “picture” and any variation of them. They also need to be readable; they are not code.

  • The only headings ⚠️ in this component are the names of each individual; “Daniel Clifford”, “Jonathan Walters”, “Jeanette Harmon”, “Patrick Abrams” and “Kira Whittle”. Everything else should be wrapped in a paragraph element.

  • The web development process can be made easier and expedite the process 🚀 by implementing a CSS Reset. Here are some examples that you can freely use 😁: Josh Comeau Reset, Eric Meyer Reset

  • For improved accessibility 📈 for your content, it is best practice ✅ to use em for media-queries. Using this unit gives users the ability to scale elements up and down, relative to a set value.

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 🎆🎊🪅

  0

  ---

  

  Ric•210

  @Ripra87Posted almost 2 years ago

  @vcarames Thank you so much for your comment, i never used the figure element, i'm going to read and check about it and try in the next project!!

  ---

  I also never heard about the css reset, thank you for these links, i'm checking them right now and it's really interesting, thank you!!

  ---

  I will start using the em instead for media queries too )

  ---

  Thank you again for your comment and Happy Coding!

  0