Design comparison
Solution retrospective
Feedback is welcomed
Community feedback
- @AgataLiberskaPosted over 3 years ago
Hi @xStef23! Take a look at the report after uploading your solution - it looks like you're using the same id more than once which invalidates your HTML (id's must be unique). In general, styling using id's makes a lot of people unhappy (but then again, many people have no problem with it at all).
Also, there's quite a lot of empty space at the bottom of each card if you look at the screenshot of your solution - that's because you set up the height of the container to 100vh. I would get rid of that completely and let the content determine the height. You can then place the grid in the middle of the screen using
display: grid; place-items: center
on thebody
element.I also noticed that Jeanette's name is underneath the picture on the card, I think the markup is a bit different in that card than in the other ones.
Overall I think it looks pretty good and everything seems responsive!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord