Testimonials grid section

Community feedback

• 

  T

  Grace•31,270

  @grace-snowPosted about 4 years ago

  Hi there,

  I'm just previewing on mobile, but the css grid stuff looks fine to me. If you want to improve it, I'd look into area and line names next, as all the numbers (especially written in shorthand) are difficult to read. If you used grid line or area names, other developers would be able to see where everything is placed on your grid at an easy glance.

  I also think your layouts would be easier if you went mobile first with css / media queries.

  Only other point for improvement is on alt text. As an assistive technology user, it wouldn't tell me anything to hear 'user 1 read out as an image description. Better to use the person's name or leave alt intentionally blank.

  That's all from me. Well done on. This and keep going! 👏 ☺

  2

  ---

  

  Alfredo Carreón Urbano•125

  @AlfredoCUPosted about 4 years ago

  Hey @grace-snow, Thanks for the comments--super helpful! :D

  1
• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted about 4 years ago

  Hey, Alfredo Carreón Urbano! 👋

  Good work on this challenge! Your solution looks good and is responsive! 👏

  I suggest,

  • Setting a max-width on the grid in the desktop layout of the site so that the content of the page doesn't look too stretched on extra-large screens.
  • Decreasing the space to the left and right sides of the grid before the layout changes at 64em would give the content of the page some more room and prevent it from looking too squeezed right before the layout changes.

  Keep coding (and happy coding, too)! 😁

  1

  ---

  

  Alfredo Carreón Urbano•125

  @AlfredoCUPosted about 4 years ago

  Thanks @ApplePieGiraffe! Happy coding to you, too!

  0