Testimonials Grid using CSS Grid and Flexbox

Community feedback

• 

  バレンタイン 😈•64,190

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • Do not forgot to check your FEM report, to see what is incorrect and update your code with it right after you submit your challenge.

  • To properly center your content to your page, you will want to add the following to your Body element (this method uses CSS Grid):

  body {
      min-height: 100vh;
      display: grid;
      place-content: center;
  }
  

  More Info:📚

  Centering in CSS

  • The profile images alt tags need to be improved. It should state the following; “Headshot of -person’s full name-“

  More Info:📚

  Headshot Alt Text

  • The names of each individual are headings so they should be wrapped in a Heading Element. Since they are all equal level of importance, the h2 heading will be the best choice.

  • To improve the semantics of your component, you will want to wrap each individual testimonial component in a figure element, the individuals information should be wrapped in a figcaption element and lastly, the testimonial itself should be wrapped in a blockquote element.

  Code:

  <figure>
     <figcaption></figcaption>
     <blockquote></blockquote>
  </figure>
  

  More Info:📚

  MDN Figure Element

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 🎄🎁

  Marked as helpful

  0

  ---

  

  バレンタイン 😈•64,190

  @VCaramesPosted almost 2 years ago

  • Your CSS Reset is being underutilized. To fully maximize it, you will want to add more to it.

  Here are some examples that you can freely use:

  Josh Comeau Reset

  Eric Meyer Reset

  • For improved accessibility 📈 for your content, it is best practice to use rem for your font-size and other property value. While em is best for media-queries. Using these units gives users the ability to scale elements up and down, relative to a set value.

  • Using CSS grid with grid-template-areas will make things way easier when building the layout and give you full control of it.

  Here is how it looks like fully implemented: EXAMPLE

  Marked as helpful

  0

  

  Gulz•110

  @GulzhubPosted almost 2 years ago

  @vcarames thank you for your awesome feedback and suggestions. I'm pretty newbie in this and I just tried to match the design provided. I have incorporated some of your suggestions. I liked how easy it is to center using grid. I will definitely keep in mind to add a proper reset from the next time. Do you mind sharing any of your socials? I would love to connect.

  Thanks and regards.

  0