Testimonials grid section

Community feedback

• 

  Arturo Simon•1,785

  @artimysPosted almost 4 years ago

  Great job with the challenge Esteban 👍👍. You captured the testimonial card details really well.

  The only feedback I will provide is to organize your css classes to remove duplicating styles. For classes div.testimonial__grid1 through div.testimonial__grid4, they share a lot of common styles that make up the card.

  I'll leave a simple example on how to approach it below. You can change the names to your liking. I'm just naming them using the BEM way. More info on BEM if interested

  .testimonial-card {
      display: flex;
      flex-direction: column;
      padding: 30px;
      border-radius: 10px;
      box-shadow: 10px 10px 110px -51px rgba(0, 0, 0, 0.75);
  }
  .testimonial-card--grid1 { 
  // add specific styles that make grid1
  }
  .testimonial-card--grid2 { 
  // add specific styles that make grid2
  }
  
  <div class="testimonial-card testimonial-card--grid1">
      ....
  </div>
  <div class="testimonial-card testimonial-card--grid2">
      ....
  </div>
  

  Great work!! Keep on coding 👍

  1

  ---

  

  Esteban Castaño Rivera•40

  @zidoxxPosted almost 4 years ago

  @artimys thanks for the feedback, im just starting in BEM and i have some difficulties to understand it, thanks for the info, and sorry for my poor english.

  0