Testimonial grid using CSS GRID & Flexbox

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hi there 👋. Good job on completing the challenge !

  I have some feedback for you if you want to improve your code.

  • You must use a level-one heading (h1) even though this is not a full-page challenge. You can create an '<h1>' element within your 'main' element that will be hidden visually but visible and readable by screen readers. The class "sr-only" hides content visually and here are the styles to copy. e.g.: <h1 class="sr-only">Testimonials grid section</h1>

  • The image with the testimonial author is not a decoration, you need to improve the alternative text to tell the user who is the author of the testimonial, its recommended to use the author's name as the alt attribute value. e.g. alt="Daniel Clifford"

  • The alt attribute should not contain the words "image", "photo", or "picture", because the image tag already conveys that information.

  If you want to learn more about the alt attribute, you can read this article.

  • To improve the semantics of your code you should use the <figure> and <blockquote> tags to wrap the testimonials, with this, you will be able to encapsulate the author and the citation of the testimonial.

  Example:

  <figure>
  	<blockquote>
  		<p>"Example of a testimonial"</p>
  	</blockquote>
  	<figcaption>
  		<p>Example of the author</p>
  	</figcaption>
  </figure>
  

  You can read more about the <figure> and <blockquote> tags with this two links:

  1. Quotations, Citations, and Blockquotes | CSS-Tricks
  2. Quotations | MDN Web docs

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  Marked as helpful

  1

  ---

  

  Zosima•220

  @SantiagoPoncePosted almost 2 years ago

  @MelvinAguilar Hi! thank you very much for your recommendations and study material, they are always very useful. I've already edited the content of the alt attributes and included the header for the screen reader (although for some reason my phone's talkback doesn't register it). Regarding the blockquote tag, I'll read it shortly. Thank you very much as always :D

  (sorry for my English )

  1