Testimonials Grid Section

Community feedback

• 

  Heli0s•670

  @zeerobitPosted over 2 years ago

  well done on completing this challenge, however i have a few remarks:

  • use more semantics in your html than just div.. look into figure, figcaption and blockquote which are more suitable semantics for this challenge. Basically each card should be wrapped with the figure tag instead of div, the photo along with the name and title should be wrapped in figcaption and the paragraphs in blockquote.
  • You should research about grid-areas as it would be a lot easier for the desktop layout, you would use a lot less code. Here is an example of the code for my grid desktop layout:

      display: grid;
      grid-template-columns: repeat(4, 1fr);
      column-gap: 1.2rem;
      grid-template-areas:
        "card1 card1  card2 card5"
        "card3 card4  card4 card5 ";
    }
  

  hope this helps, happy coding

  1

  ---

  

  Ritik Raj•20

  @ritik48Posted over 2 years ago

  @zeerobit Thank you so much for reviewing my code, and yes I mostly use div's to pack items as I am not much aware of the semantics but will definitely research about it. And I didn't know about grid-areas , I just looked into and it is really great in displaying elements in different layouts.

  0