Testimonials grid section challenge hub

Community feedback

• 

  T

  Alex•2,010

  @AlexKMarshallPosted about 3 years ago

  On a big screen this looks good, but when we shrink the size of the screen everything overflows. You've used a lot of fixed pixel sizes which is what is making things inflexible. You're using CSS Grid, so you can take a look at the responsive sizing values like fr which will help to solve this issue. Make sure to test your code at a range of different screen sizes to make sure that it behaves well in all situations.

  Also, it's important to pay attention to the details. There are a few places where you have extra quotation marks in the copy, or a misplaced word, and missing capitalization. Always proof-read your output after taking a little break from it. That way you will more easily spot mistakes than when you've spent a long time focussing on the project.

  Finally, it's important to be careful with the use of heading elements. There should be only one <h1> element on a page. Here it's more difficult, because this design isn't really for a whole page, just for a small section of one, so in cases like these it's worth having a single page title <h1> element and hiding it visually if it's not in the design. Then you can use <h2>s for your section headers.

  Marked as helpful

  1
• 

  Natnael Fanta Teffera•110

  @nasheePosted about 3 years ago

  Hello Alex, I have improved the design based on your suggestion.

  0
• 

  Natnael Fanta Teffera•110

  @nasheePosted about 3 years ago

  Thank you! Alex, I will go through it and fix the issue.

  0