
Design comparison
Community feedback
- P@morauszkiaPosted about 1 month ago
I agree with Yacoub, that you shouldn't use semantic html elements for other purposes, than they are originally meant for. Also, I think, you should awoid hardcoding the width of these elements using absolute units, instead, you could let the content influence the size, and use the grid-template-areas, as you already do, to nicely align the items.
0 - @YacoubDweikPosted about 1 month ago
Good job!
All these cards should be articles or sections, don't make it like a cocktails nav aside main :P main > 5 articels.
I got crazy trying to find what makes your design overflows in phones and finally I realized it's that quotation marks svg, give it position absolute then position relative give for that card, then using top: 0 & right: 0 this way you will have it exactly in that upper right angle.
No need to set body flex.
Keep it up you are on the right track! just make sure the resource that you are learning from is good.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord