Testimonials grid section by Ramz001

Community feedback

• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted about 3 years ago

  see if the following can help, i have commented out the code that i think is not needed in mobile

  .container {
  	grid-template-columns: 1fr;
  	/* grid-template-rows: repeat(9, 15rem); */
  	/* grid-area: "user-1" "user-2" "user-3" "user-4" "user-5"; */
  	
  	justify-items: center;
  }
  
  .container {
  	background: var(--light-gray);
  	background-size: cover;
  	display: grid;
  	/* grid-area: "user-1 user-1 user-2 user-5" "user-3 user-4 user-4 user-5"; */
  	/* grid-template-columns: repeat(4,18rem); */
  	/* grid-template-rows: 300px 300px; */
  	grid-gap: 2rem;
  	padding: 5rem 2rem; //adjust your padding
  }
  

  Marked as helpful

  0

  ---

  

  Ramz•375

  @Ramz001Posted about 3 years ago

  @ChamuMutezva In the code instead of writing grid-template-areas i wrote grid-area so my code was not working properly i mean it worked only due to grid-column and grid-row so after dinding that error no code is much smaller and more semantic

  1
• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted about 3 years ago

  • the design is close on desktop but for mobile and medium devices , there is still some work to be done. Some content are hidden or cut off from view
  • using !important in your css is a sign that you need to revisit your styling - it is something you need to resist unless maybe when overriding some framework styling.
  • if the image is just for decoration use alt="" , <img src="images/bg-pattern-quotation.svg" alt="background" class="quote-svg">. Alt values should benefit assistive tech users to visualize the message that is being put across.
  • an inline element like a span should not be used to be a parent of a block element div

  <span>  
              <div>Kira Whittle</div>
              <div class="user-level">Verified Graduate</div>
          </span>
  

  • use semantic html where possible ahead of elements like a div

  0

  ---

  

  Ramz•375

  @Ramz001Posted about 3 years ago

  @ChamuMutezva First of all thanks for the feedback I've changed the code for a bit by deleting div and writing p instead as well as deleting !important and position media query in the bottom of the CSS ,but here's the thing that I cannot do much of thing in the mobile view I mean neither justify-content nor justify-self is working so that I can center the items and make them a little bigger. Could you suggest anything in particular ?

  0