Testimonials grid section

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hello again 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  • In my humble opinion, the breakpoint value is too small, you should use a bigger one, or implement another media query to adjust elements on tablet devices. Image (425px wide):

    screencapture-ahmedalaa109-github-io-Testimonials-grid-section

  • The alt attribute should not contain the words "image", "photo", or "picture", because the image tag already conveys that information.

    If you want to learn more about the alt attribute, you can read this article. 📘.

  • A small tip: To improve the semantics of your code you should use the <figure> and <blockquote> tags to wrap the testimonials, with this, you will be able to encapsulate the author and the citation of the testimonial.

    Example:

    <figure>
       <blockquote>
          <p>"Example of a testimonial"</p>
       </blockquote>
       <figcaption>
          <p>Example of the author</p>
       </figcaption>
    </figure>
    

    You can read more about the <figure> and <blockquote> tags with this two links:

    1. Quotations, Citations, and Blockquotes | CSS-Tricks
    2. Quotations | MDN Web docs

  I hope you find it useful! 😄

  Happy coding!

  0

  ---

  

  ahmedalaa109•80

  @ahmedalaa109Posted almost 2 years ago

  @MelvinAguilar Always wonderful feedback thank you so much <3 I put them in my consideration in my next designs thank you so much

  0