Design comparison
SolutionDesign
Solution retrospective
What are you most proud of, and what would you do differently next time?
I proud of completing this challenge!
What challenges did you encounter, and how did you overcome them?how to make the row height dynamic and fit the content.I solved that using grid-auto-rows: auto
What specific areas of your project would you like help with?Anything that can help me improve.
Community feedback
- @john-miragePosted 8 months ago
Hello, nice work
Here some ways you can improve your project:
- You should consider moving your css in a different file, it is more clean this way.
- You should add a container for the cards so the width is fixed and the cards dont stretch.
- In the <head> you forget to rename the <title>
- To help you start a project, you can add a css reset file. It defines some rules to ease your workflow.
- You can add meta tags in your <head> element to display informations and an image for Google and the social medias like facebook and twitter.
- The images can be converted in webp format, webp format compress images more so you get less loading time.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord