Testimonials Grid Section. Any Feedback is Appreciated!
Design comparison
Solution retrospective
It was suggested that I try using the BEM naming convention for my CSS, so I've tried to implement that with this project. I'm not entirely sure if I've used this correctly, so any feedback would be much appreciated!
Community feedback
- @hardy333Posted about 3 years ago
Hi matt.
Everything looks good and responsive -- nice job.
For BEM, yes you have done good job using it. only one suggestion is to use "--" instead of "-" for class: .card-two, .card-one, .card-light ... so they become: .card--one .card--two, .card--light, using double dashes is rule in BEM, becouse if you need classname whith two words for example .img-container it is different form .img--container, container is not modifies image xD but img-container is hole seperate element/component. That is way bem uses double dashes - single dashes is already taken xD.
3@mattyoung7Posted about 3 years ago@hardy333 Thank you so much for taking the time to comment - this feedback means a lot! I'll make sure to do the double hyphen next time!
2
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord