@geomydas
Posted
Can't really give proper feedback since the github repo link is broken
@geomydas Oh I set it to private by mistake, should be okay now, thx :D
@geomydas
Posted
@MateuszZalew
For the file structure, make sure to add a .gitignore so you can exclude files that wont be needed by other people such as configs and dependencies like node_modules, package,json, .vscode and the like.
I reccomend replacing the <article> tags on your code with <section> tags. There's really no need to use an article and the only times you will use an article tag is in blog posts or news homepages.
You can add a visually hidden <h1> with some text so that it wont skip into h2s immediately.
You should also never use #ids for styling and just use multiple classes on an element
For example:
<article class="card" id="card__patrick">
To:
<article class="card card_patrick>
Use a CSS reset aswell. It makes your css look the same on all devices and makes your experience much more easier aswell. You just copy and paste it in your code, and voila!.
Most people either use Andy Bell's or Josh Comeau's css reset
Marked as helpful
@geomydas Very nice tips, thank you!
