Ok a few things to work on for now
- try to do mobile first (use a min-width media query to change layout as screen size increases
- take another look at your solution on a mobile - central column is really narrow at the moment (I'll add a screenshot to slack for you)
- remember to use semantic html elements where possible, and add alt text to images (or leave alt empty if image isn't meanigful/needed for those using assistive tech)
I'm not sure about your class names... Are you trying to follow a BEM convention? I can see underscores and hyphens but they're not consistently used so I wasn't sure. I wouldn't worry about that anyway for now, as long as the classes do what you want don't worry about naming. Over time they'll get clearer.
Well done on trying your first challenge! Have fun coding 😊
1
Maxence Yrowah• 155
@maxenceyrowah
Posted
@grace-snow thanks so much for the feedback
1
