testimonial section submission

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • The article element is not the best choice ❌ for wrapping these testimonials. In order to use the article element the component needs to be able to make sense on its own and be independently distributable (can be used in on another site). These testimonials cannot do neither.

  More Info:📚

  MDN Article Element

  • The only headings ⚠️ in this component are the names of each individual; “Daniel Clifford”, “Jonathan Walters”, “Jeanette Harmon”, “Patrick Abrams” and “Kira Whittle”. Everything else should be wrapped in a paragraph element.

  • The profile images are not decorative ❌. Their alt tag should not be blank. It should state the following; “Headshot of -person’s full name-“

  More Info:📚

  Headshot Alt Text

  • For the testimonials, it is best ✅ to to wrap each individual testimonial component in a figure element, the individuals information should be wrapped in a figcaption element and lastly, the testimonial itself should be wrapped in a blockquote element.

  Code:

  <figure>
     <figcaption></figcaption>
     <blockquote></blockquote>
  </figure>
  

  More Info:📚

  MDN Figure Element

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 🎆🎊🪅

  Marked as helpful

  0

  ---

  

  Esteban•340

  @estebanp2022Posted almost 2 years ago

  @vcarames thank you for all your insight. I did debate on whether I should use <article> or not. I've never used <figure> but that makes much more sense!

  I'm a bit unsure on using <figcaption>. Per MDN: 'The <figcaption> HTML element represents a caption or legend describing the rest of the contents of its parent <figure> element'. The person's name + 'verified graduate' is not adding a caption (or describing) the contents of its parent; so I settled on wrapping it with a <div> instead.

  Thanks again!

  0

  

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  @estebanp2022

  Glad I could help! 😁

  You are correct. Currently it makes no sense. But that is because you are looking at it as five testimonials and nothing more.You want to look at the bigger picture.

  This “section” makes no sense on its own. In a real website. There would be a heading stating something like, “Testimonials", etc…

  Now having the name and "verified graduate" inside a figcaption it does add caption do it.

  The heading will tell you what to expect and the the names tell us what testimonial we are reading.

  These smaller challenges are all reusable and can be modified to fit practically any website, you creat now and in the future. Always think big picture.

  Hope that clears things up.

  0