Testimonials grid section

Community feedback

• 

  Abdul Khaliq 🚀•72,580

  @0xabdulkhaliqPosted 6 months ago

  Hello @mhykah-webdev 👋. Congratulations on successfully completing the challenge! 🎉

  • I have a suggestion regarding your code that I believe will be of great interest to you.

  ---

  MAKING ACCESSIBLE TESTIMONIALS :

  • Currently the Testimonials are not accessible because of the usage of non-semantic div element, Actually we need to use <figure> and <blockquote> elements to wrap the testimonials.

  ---

  • For example:

  <figure>
    <figcaption>
      <img src="./assets/images/image-daniel.jpg" alt="Daniel Clifford" />
      <div>
        <p>
          <span class="sr-only">Testimony Author</span>
          Daniel Clifford
        </p>
        <p>Verified Graduate</p>
      </div>
    </figcaption>
    <blockquote>
      <h2>
        Testimonial Title 
        ... 
      </h2>
      <p>
         Testimonial Quote 
         ...
       </p>
    </blockquote>
  </figure>
  

  ---

  • Additionally, you want to add proper alt for img inside testimonials because they are not for decoration, It will help us to tell the user who is the author of the testimonial, its recommended to use the author's name as the alt attribute value like alt="Daniel Clifford"

  ---

  • If you have any questions or need further clarification feel free to reach out to me.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0
• 

  Denchiks•300

  @Denchiks37Posted 6 months ago

  Almost pixel perfect project. For colors you can use element in the beginning of your style css file by writing

   :root{}
  

  For example

  :root {
    --moderate-violet: hsl(263, 55%, 52%);
    --very-dark-grayish: hsl(217, 19%, 35%);
    --very-dark-blackish: hsl(219, 29%, 14%);
    --white: hsl(0, 0%, 100%);
    --light-gray: hsl(0, 0%, 81%);
    --light-grayish: hsl(210, 46%, 95%);
  }
  

  And later in code call him using names you gave them

  .card-purple {
    background-color: var(--moderate-violet);
  }
  

  I hope it was helpful)

  Marked as helpful

  0