Design comparison
Solution retrospective
I think the project came out quite accurate to the original design.
What challenges did you encounter, and how did you overcome them?Nothing major.
What specific areas of your project would you like help with?I'd like to know if there are a better way for me to use classes to apply things such as colours and borders. Any general feedback or advice would be greatly appreciated!
Community feedback
- @0xabdulkhaliqPosted 7 months ago
Hello @mhykah-webdev 👋. Congratulations on successfully completing the challenge! 🎉
- I have a suggestion regarding your code that I believe will be of great interest to you.
MAKING ACCESSIBLE TESTIMONIALS :
- Currently the Testimonials are not accessible because of the usage of non-semantic
div
element, Actually we need to use<figure>
and<blockquote>
elements to wrap the testimonials.
- For example:
<figure> <figcaption> <img src="./assets/images/image-daniel.jpg" alt="Daniel Clifford" /> <div> <p> <span class="sr-only">Testimony Author</span> Daniel Clifford </p> <p>Verified Graduate</p> </div> </figcaption> <blockquote> <h2> Testimonial Title ... </h2> <p> Testimonial Quote ... </p> </blockquote> </figure>
- Additionally, you want to add proper alt for
img
inside testimonials because they are not for decoration, It will help us to tell the user who is the author of the testimonial, its recommended to use the author's name as the alt attribute value likealt="Daniel Clifford"
- If you have any questions or need further clarification feel free to reach out to me.
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
Marked as helpful0 - @Denchiks37Posted 7 months ago
Almost pixel perfect project. For colors you can use element in the beginning of your style css file by writing
:root{}
For example
:root { --moderate-violet: hsl(263, 55%, 52%); --very-dark-grayish: hsl(217, 19%, 35%); --very-dark-blackish: hsl(219, 29%, 14%); --white: hsl(0, 0%, 100%); --light-gray: hsl(0, 0%, 81%); --light-grayish: hsl(210, 46%, 95%); }
And later in code call him using names you gave them
.card-purple { background-color: var(--moderate-violet); }
I hope it was helpful)
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord