Submitted over 1 year ago

Testimonials Grid Section

Ana•230

@alauram

Preview site View code

This is a solution for...Testimonials grid section

HTML
CSS

2junior

Design comparison

SolutionDesign

Solution retrospective

Once again, I had trouble putting the background image, it worked well on my device, but when I uploaded it to GitHub it disappeared and I couldn't put it back. Does someone have a solution?

Community feedback

Vanza Setia•27,775
@vanzasetiaPosted over 1 year ago
Hi, Ana! 👋

For the quotation icon, you should change the path from background-image: url('../images/bg-pattern-quotation.svg') to background-image: url('./images/bg-pattern-quotation.svg').

Three things that can be done better.

Replace the <div class="detail"> with <blockquote>. It is a quote so it should be wrapped by a quote element.

Never use px unit for font sizes. Use rem or em instead. Relative units such as rem and em can adapt when the users change the browser's font size setting. Learn more — Why you should never use px to set font-size in CSS

Prefer unitless numbers for line-height values to avoid unexpected results. Learn more — line-height - CSS: Cascading Style Sheets | MDN

I hope this helps. Happy coding! 👍
Marked as helpful
1
Ana•230
@alauramPosted over 1 year ago
@vanzasetia Thank you so much for your help and suggestions!
0
Vanza Setia•27,775
@vanzasetiaPosted over 1 year ago
@alauram

No problem! I am glad I could help.
0

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord