Design comparison
Solution retrospective
Fourth Junior Frontend Mentor Challenge(Responsive Testimonial Grid Section ) take some time to complete specifically Grid layout. But I am happy to achieve this mile stone. Thanks you.
Any feedback will be appreciated.
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- The profile images are not decorative ❌. Their
alt tag
should not be blank. It should state the following; “Headshot of -person’s full name-“
More Info:📚
- The only headings ⚠️ in this component are the names of each individual; “Daniel Clifford”, “Jonathan Walters”, “Jeanette Harmon”, “Patrick Abrams” and “Kira Whittle”. Everything else should be wrapped in a
paragraph
element.
- For the testimonials, it is best ✅ to to wrap each individual testimonial component in a
figure
element, the individuals information should be wrapped in afigcaption
element and lastly, the testimonial itself should be wrapped in ablockquote
element.
Code:
<figure> <figcaption></figcaption> <blockquote></blockquote> </figure>
More Info:📚
- Your
CSS Reset
is being underutilized. 😢 To fully maximize 💯 it, you will want to add more to it.
Here are some examples that you can freely use:
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🎆🎊🪅
0@zahirpkPosted almost 2 years ago@vcarames Thanks again for giving me valuable tips
0 - The profile images are not decorative ❌. Their
- Account deleted
I have one suggestion for your solution to improve
- I notice the font-size of your paragraph is too small because of that it will make your paragraph hard to read. to fix that try to change their font-size into 16px because this is the standard font-size when it comes to the font-size of a paragraph.
0@zahirpkPosted almost 2 years ago@okayda Thank you very much for valuable tip about font-size. but in design, "body font recommended 13px". what why i use it.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord