Design comparison
Solution retrospective
Feel free to leave any feedback below so that I can improve this even further! Thank you very much.
Community feedback
- @correlucasPosted over 2 years ago
👾 Hello Ly Dinh, congratulations for your solution!
I'm with your live solution open and you've done pretty much anything. There's only one small detail to fix, the paragraphs are a little bit smaller, if you pay attention you'll see that the right white card (Kira White) isn't filling the card space and there's a big gap in the bottom, this is due the font-size you choose for the
p
. Also the card title didn't have the properfont-size
,line-height
andfont-weight
.You need to play around with these
p
values I've done some tests with the class related to this paragraphs and a value that's close is1.5rem
. Note that also the card title isn't with the correct font-size so this changes all the card design. See the correction for the card paragraph:.card-more-info { color: hsla(0, 0%, 100%, 0.7); font-size: 1.5rem; }
Hope it helps you, happy coding!
Marked as helpful1@winprnPosted over 2 years ago@correlucas Hi, I did pay some attention to this while styling, but the style said that the font size should be 13px (in the included style-guide.md) so I didn't play around with that value. I'll spend some time fixing and updating soon! Thank you.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord