Testimonials grid section

Community feedback

• 

  Szymon Rojek•4,540

  @SzymonRojekPosted almost 4 years ago

  Hi Victor again,

  Another challenge, well done :D

  I have checked your another project Four card feature section so please have a look because lots of points can be included here:

  • you have used so many nested wrappers divs and this is unnecessary => try to simplify it;
  • don't have to use ID's here => that's a reason why we have got classes. I'd suggest learning BEM naming convention in English as a universal language for programmers;
  • this is a single page component so you can add the h1, for example with the class sr-only hidden for the Screen Readers, then instead of the h3 use the h2 because we can not skip the headings;
  • RWD: check a project by using the inspector in your browser on different devices, especially on tablets, these cards could have a different pattern: create two rows with two boxes and below the fifth (named Kira) could be along the length of the entire container;
  • the same problem with the height and width (check Four card feature section project).

  I'd recommend reading more about semantic tags, headings, width and height when using flexbox && grid.

  Ps. Please, don't forget to upvote any comments on here that you find helpful.

  Greetings :D

  1

  ---

  

  Victor Rios•70

  @vicru5Posted almost 4 years ago

  @SzymonRojek Thank you so much for all your feedbacks i will learn all about you tell me, is very important for me because i'm learning html and css but i don't have the experiencie that you have and good practices that a good developer must to have i will take a look to the points and then made a rebuild of the projects, thank you again

  0