Testimonials grid section

Community feedback

• 

  P

  Emmilie Estabillo•5,540

  @emestabilloPosted almost 4 years ago

  Hey Kevin, great stuff here. Desktop version as seen on the screenshot looks solid. For medium and smaller widths though, the component looks off-center because it is following the declaration of the grid columns with minmax(255px, 327px). I would probably try using:

  1. max-width for the main .grid container to make it fluid, and

  2. maybe fractional units for the columns instead of hard coded values so that the grid is not waiting for the next 255/327px of space to create another column and thus, not render that huge empty space on the right while in the process of "waiting".

  As for 1:1, I'm also a fan of it. Responsiveness beats it hands down though (my opinion). Here's a great article that was shared on the Slack channel recently that might be relevant. As you've probably guessed by now, the jpg version is taken from the original Sketch file :-)

  2

  ---

  

  Kevin Canlas•225

  @kvncnlsPosted almost 4 years ago

  Thank you so much!! I still find it difficult to develop the parts between the designed mobile and desktop versions. Everything in between is almost like guess-work to me haha. I'll fix this up ASAP!

  1
• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 4 years ago

  Hey, Kevin Canlas! 👋

  Nice job on this challenge! 👏

  Just wanted to say, after recently getting my hands on the Sketch/Figma design files, I also noticed there were some small discrepancies between them and the design JPGs. I thought I might be going crazy, too, but I guess that's simply how it is. I usually end doing a combination of both using the units and styles specified in the design files and eyeballing it from the JPGs if I really want my solution to match up in the design comparison. 😊

  As emestabillo mentioned, centering the grid in the tablet/mobile layouts would be a good idea and I think adding a little bit of space (using margin or padding) between the last testimonial card and the bottom of the screen would nice, too. 😉

  Keep coding (and happy coding, too)! 😁

  1

  ---

  

  Kevin Canlas•225

  @kvncnlsPosted almost 4 years ago

  @ApplePieGiraffe Thank you for the feedback!! I'm really enjoying Frontend Mentor so far, I'm glad the community here is active in giving great feedback. Thank you!

  0