Testimonials-grid-section using GRID

Community feedback

• 

  Precious Nkwor•440

  @Jeen-PreshPosted almost 2 years ago

  Hello syed, congratulations on completing the fem challenge, keep it up.

  some suggestions to help improve your projects

  • For the testimonials it should be wrapped inside a figure element and the user information, such as the name and status can be wrapped in a figcaption element. the testimonial itself should be wrapped in a blockquote element.

  For more info MDN link figure element

  • The headings are meant to be the user's name.

  Happy coding. if you found this helpful, make sure to mark it as helpful thanks.

  Marked as helpful

  0
• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hello there 👋. Good job on completing the challenge !

  I have some feedback for you if you want to improve your code.

  HTML 📄:

  • The alt attribute should not contain the words "image", "photo", or "picture", because the image tag already conveys that information.

    If you want to learn more about the alt attribute, you can read this article. 📘.

  • Having two or more h1 tags in a webpage is not recommended because it can be confusing for search engines. Search engines use the h1 tag to determine the main topic of a page

  CSS 🎨:

  • Instead of using pixels in font-size, use relative units like em or rem. The font-size in absolute units like pixels does not scale with the user's browser settings. This can cause accessibility issues for users who have set their browser to use a larger font size. You can read more about this here 📘.

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  0