Responsive Grid Section

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hello again 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  HTML 📄:

  • The alt attribute should not contain the words "image", "photo", or "picture", because the image tag already conveys that information.

    If you want to learn more about the alt attribute, you can read this article. 📘.

  CSS 🎨:

  • Use min-height: 100vh instead of height: 100vh. The height property will not work if the content of the page grows beyond the height of the viewport.

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  Marked as helpful

  1

  ---

  

  Ansly•290

  @Median21Posted almost 2 years ago

  @MelvinAguilar Thank you very much and noted! ^_^

  0
• 

  frontendcracker•100

  @arrKhange1Posted almost 2 years ago

  Hello! It's almost great solution but there are a bit features to add:

  1. As for your problem, I would reorder elements on middle screens or even start a medium screen breakpoint a bit further
  2. Also, you got a container wrapping your grid. It's alright but if you had it with such params as:

  width: 80%;
  max-width: 1440px;
  

  or the tricky one that does the same:

  width: min(80%, 1440px);
  

  it would be 2 times greater cause this way you would limit the content width to increase readability and also avoid too expanded content on wide monitors

  Marked as helpful

  1

  ---

  

  Ansly•290

  @Median21Posted almost 2 years ago

  @arrKhange1 Thank you so much for the feedback and tips! Cheers! I will see to it in a little while :)

  0