@correlucas
Posted
👾Hello Kevin Tatagiba, Congratulations on completing this challenge!
You need to fix the container size
that is a bit off, this challenge uses the standard container size that is max-width: 1110px
.
main {
max-width: 1110px;
display: grid;
grid-template-columns: repeat(4, 1fr);
grid-template-rows: repeat(2, 300px);
gap: 30px;
padding: 12em;
justify-items: center;
align-items: center;
}
Something you can do is to improve your html markup using meaningful tags and replacing the divs. In this case, for example the main block/div that takes all the content can be wrapped with <main>
or section, if you think about = the cards you can replace the <div>
that’s wrapping each card with <article>
you can wrap the paragraph with the quote with the tag <blockquote>
this way you'll wrap each block of element with the best tag in this situation. Note that <div>
is only a block element without meaning, prefer to use it for small blocks of content inside bigger blocks wrapped with some better markup.
✌️ I hope this helps you and happy coding!
Marked as helpful
@kevintata
Posted
@correlucas Hey, Thank you so much for the feedback! (Valeu demais hahaha) I figured I got the padding wrong and changed it to 12em. I cant see any difference using max-width, What would that do exactly? Valeu demais meu irmao, Bom ver os BR representando!
@correlucas
Posted
@kevintata Foi mal irmão, pelo sobrenome não consegui ver que vc era BR. Pra não ficar com um gap lateral enorme, pra versão mobile coloque grid-template-color: 1fr
pra deixar os cards crescerem a largura inteira ao inves de ficarem concentrados com a largura que vc definiu.
Marked as helpful