Design comparison
SolutionDesign
Solution retrospective
Hello guys, this is my solution. I would appreciated any Feedback :)
Community feedback
- @grace-snowPosted over 3 years ago
Really weird, on first load, this was scrambled for me, now it all looks great! Must have been my Internet connection stumbling! 😂
1@blurrypxlPosted over 3 years ago@grace-snow Wow, really?😅 Thankyou for your feedback btw😄
0@grace-snowPosted over 3 years agoOk so this looks really good. There are just a few issues with the css I recommend you look at
- font size must never be in pixels. Really important to use rem/em
- use margin to space out items not br in html
- you are nesting css selectors extremely deeply at the moment - a common problem when people are new to using sass. Besides making the css long and bloated in bigger projects that will cause lots of issues because of the high specificity. Look into how to keep specificity low in css. Usuay single class selectors are the best way to go. The only things I nest in scss are media queries and pseudos.
I hope that helps you. Good luck
1@blurrypxlPosted over 3 years ago@grace-snow Well noted! Thank You for your suggestion, I really appreciated that (;
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord