My Testimonials Panel Solution with Flexbox

Community feedback

• 

  ANDRES•180

  @t0ntinPosted almost 2 years ago

  Hello. Delete the background img from your html file, then add this to your css code:

  .t1 {
    background-color: hsl(263, 55%, 52%);
    background-image: url(/images/bg-pattern-quotation.svg);
    background-size: 110px;
    background-position: top 5px right 30px;
    background-repeat: no-repeat;
  }
  

  That will fix the background. Also delete the code under .quotes-img...

  I like how you did it all with flexbox.

  Marked as helpful

  2

  ---

  

  Sebastian•60

  @SebasAran16Posted almost 2 years ago

  @t0ntin Thank you very much Andres!

  Really helpful, did not think about making it a background-image. Already did my reasearch about the attributes. 💯

  0
• 

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • Your **HTML should have ** a main element that will assist in identifying the main content of your site.

  More Info:📚

  MDN Main Element

  • The profile images alt tags need to be improved. It should state the following; “Headshot of -person’s full name-“

  More Info:📚

  Headshot Alt Text

  • The only headings in this component are the names of each individual; “Daniel Clifford”, “Jonathan Walters”, “Jeanette Harmon”, “Patrick Abrams” and “Kira Whittle”. Everything else should be wrapped in a paragraph element.

  • The article element is not the best choice for wrapping these testimonials. In order to use the article element the component needs to be able to make sense on its own and be independently distributable (can be used in on another site). These testimonials cannot do neither.

  More Info:📚

  MDN Article Element

  • To improve the semantics of your component, you will want to wrap each individual testimonial component in a figure element, the individuals information should be wrapped in a figcaption element and lastly, the testimonial itself should be wrapped in a blockquote element.

  Code:

  <figure>
     <figcaption></figcaption>
     <blockquote></blockquote>
  </figure>
  

  More Info:📚

  MDN Figure Element

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding!🎄🎁

  Marked as helpful

  1

  ---

  

  Sebastian•60

  @SebasAran16Posted almost 2 years ago

  @vcarames Thank you very much!

  Love how you structured your reply and gave me the resources, it was really helpful. Already applied those changes. I had read the MDN Docs but still had the doubt about how to use the <article>, really appretiate it, now I know how and that there is the <figure> I can use!

  0