Testimonials grid section using HTML and CSS

Community feedback

• 

  Alamin•2,000

  @CodeWithAlaminPosted almost 2 years ago

  Hi John Robert Maizo👋 Great job on completing this challenge! 🥳

  I noticed a few areas where your solution to the challenge could be improved, and wanted to share my suggestions with you.

  • Use of sr_only class: The sr_only class is used on the main heading, but it is not defined in the CSS. It is likely intended to be used as a class for hiding content from screen readers, but without any styles defined, it serves no purpose. It's better to use aria-hidden attribute on the element instead of a class.

  • Use of nth-child selectors: The use of nth-child selectors in the CSS makes it difficult to maintain and update the styles if the structure of the HTML changes. It's better to use more specific selectors, such as classes, or to use CSS Grid or Flexbox layout to achieve the desired layout.

  • Use of min() function: The min() function is not widely supported by browsers. It's better to use @supports feature query or a feature detection library like Modernizr to check browser support before using it.

  Overall, this is a very well done solution to the challenge. Great job!

  Hope I'm 👍helpful!

  Keep up the good work!😊❤️

  Marked as helpful

  0

  ---

  

  John Robert Maizo•360

  @johnmaizoPosted almost 2 years ago

  @CodePapa360 Thank you for your suggestions. I will make the changes you suggested to the website. It really helps me a lot!!

  1