Design comparison
SolutionDesign
Solution retrospective
Any feedback will be appreciated thanks
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- The
article
element is not the best choice for wrapping these testimonials. In order to use thearticle
element the component needs to be able to make sense on its own and be independently distributable (can be used in on another site). These testimonials cannot do neither.
More Info:📚
- To improve the semantics of your component, you will want to wrap each individual testimonial component in a
figure
element, the individuals information should be wrapped in afigcaption
element and lastly, the testimonial itself should be wrapped in ablockquote
element.
Code:
<figure> <figcaption></figcaption> <blockquote></blockquote> </figure>
More Info:📚
- The profile images alt tags need to be improved. It should state the following; “Headshot of -person’s full name-“
More Info:📚
- Your use of heading is incorrect, the
h1
is only allowed to be used once per page.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding!🎄🎁
Marked as helpful0 - The
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord