Testimonials Grid Section

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hi there 👋. Good job on completing the challenge ! I have some feedback for you if you want to improve your code.

  HTML:

  • Use the <main> tag to wrap all the main content of the page instead of the <div> tag. With this semantic element you can improve the accessibility of your page.

  • You must use a level-one heading (h1) even though this is not a full-page challenge. You can create an '<h1>' element within your 'main' element that will be hidden visually but visible and readable by screen readers. The class "sr-only" hides content visually and here are the styles to copy. e.g.: <h1 class="sr-only">Testimonials grid section</h1>

  • The image with the testimonial author is not a decoration, you need to provide an alternative text to tell the user who is the author of the testimonial, its recommended to use the author's name as the alt attribute value. e.g. alt="Daniel Clifford"

  If you want to learn more about the alt attribute, you can read this article.

  • To improve the semantics of your code you should use the <figure> and <blockquote> tags to wrap the testimonials, with this, you will be able to encapsulate the author and the citation of the testimonial.

  Example:

  <figure>
  	<blockquote>
  		<p>"Example of a testimonial"</p>
  	</blockquote>
  	<figcaption>
  		<p>Example of the author</p>
  	</figcaption>
  </figure>
  

  You can read more about the <figure> and <blockquote> tags with this two links:

  1. Quotations, Citations, and Blockquotes | CSS-Tricks
  2. Quotations | MDN Web docs

  CSS:

  • Instead of using pixels in font-size, use relative units like em or rem. The font-size in absolute units like pixels does not scale with the user's browser settings. This can cause accessibility issues for users who have set their browser to use a larger font size. You can read more about this here.

  • To center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here. You can read more about centering in CSS here.

  body {
      min-height: 100vh;
      display: grid;
      place-content: center;
  }
  
  .container {
      max-width: 1394px;
  }
  

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding and Happy New Year! 🎉🎊🎁

  1