Design comparison
Community feedback
- @correlucasPosted over 2 years ago
๐พHello Lina, congratulations for your solution!
I just saw you live solution site and seems great, you've done a beautiful grid layout here. There are some design aspect you can improve, but the code is fine.
Here's my tips:
1.To to use another block element to contain all the cards and apply some
max-width
to keep the elements aligned, you've usedbody
with somepadding
its fine, but isn't a best practice. You can see that you container with the cards is a little bit bigger than the image reference.2.The two cards with the border around the profile photo are the purple and the black one, its a little detail but you can change it removing from the other cards and add to the purple and black card
boder: 4px solid purple;
3.Use semantical tags to wrap the cards and the quote, for example, instead of using
<div>
you can use<section>
for each card and<blockquote>
for each paragraph with the quote, this way you'll describe this elements with the exact meaninful tag for it.Hope it helps and happy coding!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord