Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Testimonials Grid Section

Sakyun 50

@Sakyun

Desktop design screenshot for the Testimonials grid section coding challenge

This is a solution for...

  • HTML
  • CSS
2junior
View challenge

Design comparison


SolutionDesign

Community feedback

@VCarames

Posted

Hey there! 👋 Here are some suggestions to help improve your code:

  • To not only improve your HTML code but to also identify the main content of you page, you will want to wrap your entire site inside the main element.

More Info:📚

MDN Main Element

  • The only headings in this component are the names of each individual; “Daniel Clifford”, “Jonathan Walters”, “Jeanette Harmon”, “Patrick Abrams” and “Kira Whittle”. Everything else should be wrapped in a paragraph Element.
  • To improve the semantics of your component, you will want to wrap each individual testimonial component in a Figure Element, the individuals information should be wrapped in a Figcaption Element and lastly, the testimonial itself should be wrapped in a Blockquote Element.

Code:

<figure>
   <figcaption></figcaption>
   <blockquote></blockquote>
</figure>

More Info:📚

MDN Figure Element

If you have any questions or need further clarification, feel free to reach out to me.

Happy Coding!🎄🎁

Marked as helpful

0

Sakyun 50

@Sakyun

Posted

@vcarames Thanks for the feedback, very precise ! Thanks i'll give it a try.

1

@danielemanca1983

Posted

Hi Sakyun,

Hope you're doing well,

Great solution to this challenge, I would just like to provide you with some constructive feedback so that you can perfect the solution even more.

  • In modern client-side development, it's best practice to wrap the content inside of a <main> tag

  • You have both a .container and a .grid classes in your mark-up, only one is necessary, you can apply the max-width and margin properties to center the container and also apply the grid properties to make the container a grid container all in one class.

As for the rest I believe you did very well, good CSS variables set-up in your stylesheet under the :root declaration and great translation of the design into code, well done.

Marked as helpful

0

Sakyun 50

@Sakyun

Posted

@danielemanca1983 Thanks for the feedback ! I will try to update that for my future designs and / or when i revisit older ones.😁

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord