Testimonials cards using Grid

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  HTML 📄:

  • The image with the testimonial author is not a decoration, you need to provide an alternative text to tell the user who is the author of the testimonial, its recommended to use the author's name as the alt attribute value. e.g. alt="Daniel Clifford"

    If you want to learn more about the alt attribute, you can read this article. 📘.

  • You must use a level-one heading (h1) even though this is not a full-page challenge. You can create an '<h1>' element within your 'main' element that will be hidden visually but visible and readable by screen readers. The class "sr-only" hides content visually and here are the styles to copy. e.g.: <h1 class="sr-only">Testimonials grid section</h1>

  • To improve the semantics of your code you should use the <figure> and <blockquote> tags to wrap the testimonials, with this, you will be able to encapsulate the author and the citation of the testimonial.

    Example:

    <div class='testimonial'>
      <figure>
        <img src="john-doe-profile.jpg" alt="John Doe">
        <figcaption>
          <p>John Doe</p>,
          <span>CEO at lorem Inc.</span>
        </figcaption>
      </figure>
      <blockquote>
        <p>"The service provided by John Doe was top-notch. lorem impsum dolor sit amet."</p>
      </blockquote>
    </div>
    

    You can read more about the <figure> and <blockquote> tags with this two links:

    1. Quotations, Citations, and Blockquotes | CSS-Tricks
    2. Quotations | MDN Web docs

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  Marked as helpful

  2

  ---

  

  Sami NASRI•240

  @SilverWings47Posted almost 2 years ago

  @MelvinAguilar Thank you. I will implement the suggestions you've made.

  1